Skip to content

Fix for issue #49#50

Merged
nikhilk145 merged 3 commits intomainfrom
feature/option-to-hanlde-r53
Sep 29, 2025
Merged

Fix for issue #49#50
nikhilk145 merged 3 commits intomainfrom
feature/option-to-hanlde-r53

Conversation

@vijay-stephen
Copy link
Collaborator

@vijay-stephen vijay-stephen commented Sep 29, 2025

Description

Please provide a brief description of the changes introduced by this pull request.

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Provide detailed steps or instructions for testing the changes introduced by this pull request.

Screenshots

Include any relevant screenshots or visual aids to help reviewers understand the changes visually, if applicable.

Additional Notes

Add any additional notes or context that might be helpful for reviewers or users testing the changes.

@sonarqubecloud
Copy link

@nikhilk145 nikhilk145 merged commit 8a8dfe7 into main Sep 29, 2025
4 checks passed
@nikhilk145 nikhilk145 deleted the feature/option-to-hanlde-r53 branch September 29, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aliases and Route53 Root Domain should be optional in CloudFront module

2 participants