Do not hardcode warnings as errors

Signed-off-by: Juan Cruz Viotti <[email protected]>
sourcemeta · Jul 31, 2023 · 29b90da · 29b90da
1 parent 2dcf6b1
commit 29b90da
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.21)
+cmake_minimum_required(VERSION 3.24)
 project("JSON BinPack" VERSION 0.0.1 LANGUAGES CXX
   DESCRIPTION "\
 A space-efficient open-source binary JSON serialization \

diff --git a/CMakePresets.json b/CMakePresets.json
@@ -6,15 +6,17 @@
       "displayName": "Release",
       "binaryDir": "build",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Release"
+        "CMAKE_BUILD_TYPE": "Release",
+        "CMAKE_COMPILE_WARNING_AS_ERROR": "ON"
       }
     },
     {
       "name": "debug",
       "displayName": "Debug",
       "binaryDir": "build",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Debug"
+        "CMAKE_BUILD_TYPE": "Debug",
+        "CMAKE_COMPILE_WARNING_AS_ERROR": "ON"
       }
     }
   ],

diff --git a/cmake/warnings.cmake b/cmake/warnings.cmake
@@ -2,7 +2,6 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "App
   add_compile_options(
     -Wall
     -Wextra
-    -Werror
     -Wpedantic
     -Wshadow
     -Wdouble-promotion
@@ -88,7 +87,7 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     # See https://www.postgresql.org/message-id/[email protected]
     -fwrapv)
 elseif(MSVC)
-  add_compile_options(/options:strict /W4 /WX /WL /sdl)
+  add_compile_options(/options:strict /W4 /WL /sdl)
 else()
   message(WARNING "Unrecognized compiler: ${CMAKE_CXX_COMPILER_ID}")
 endif()