Use ClangTidy from Noa

Signed-off-by: Juan Cruz Viotti <[email protected]>

.github/workflows/ci.yml

@@ -7,19 +7,6 @@ on:
       - 'www/**'
 
 jobs:
-  # Only run clang-tidy on GNU/Linux as a separate jobs
-  # given how expensive clang-tidy this, even more on
-  # other platforms.
-  # clang-tidy:
-    # runs-on: ubuntu-20.04
-    # if: github.ref != 'refs/heads/main'
-    # steps:
-      # - uses: actions/checkout@v2
-      # - run: sudo apt-get install --yes clang-tidy
-      # - run: cmake --version
-      # - run: cmake --preset release --log-context
-      # - run: cmake --build --preset release --target clang_tidy
-
   test:
     strategy:
       fail-fast: false

CMakeLists.txt

@@ -71,11 +71,12 @@ endif()
 if(PROJECT_IS_TOP_LEVEL)
   file(GLOB_RECURSE JSONBINPACK_CXX_SOURCE_FILES src/*.cc src/*.h test/*.cc test/*.h)
   file(GLOB_RECURSE JSONBINPACK_SH_SOURCE_FILES test/*.sh scripts/*.sh)
+  noa_target_clang_format(SOURCES ${JSONBINPACK_CXX_SOURCE_FILES})
+  noa_target_clang_tidy(SOURCES ${JSONBINPACK_CXX_SOURCE_FILES})
+
   string(TOLOWER ${CMAKE_BUILD_TYPE} JSONBINPACK_BUILD_TYPE)
   set(JSONBINPACK_WEBSITE_OUT ${PROJECT_SOURCE_DIR}/build/${JSONBINPACK_BUILD_TYPE}/www)
   set(JSONBINPACK_WEBSITE_SRC ${PROJECT_SOURCE_DIR}/www)
-  noa_target_clang_format(SOURCES ${JSONBINPACK_CXX_SOURCE_FILES})
-  include(${PROJECT_SOURCE_DIR}/cmake/clang-tidy.cmake)
   include(${PROJECT_SOURCE_DIR}/cmake/bundler.cmake)
   include(${PROJECT_SOURCE_DIR}/cmake/jekyll.cmake)
   include(${PROJECT_SOURCE_DIR}/cmake/doxygen.cmake)

GNUmakefile

@@ -41,6 +41,10 @@ debug:
 	exit 1
 endif
 
+.PHONY: clean
+lint:
+	$(CMAKE) --build --preset $(PRESET) --target clang_tidy
+
 .PHONY: clean
 clean:
 	$(CMAKE) -E rm -R -f build .bundle .sass-cache

Makefile

@@ -15,6 +15,9 @@ test: .always
 	$(CMAKE) --build --preset $(PRESET) --parallel
 	$(CTEST) --preset $(PRESET) --verbose --parallel
 
+lint: .always
+	$(CMAKE) --build --preset $(PRESET) --target clang_tidy
+
 clean: .always
 	$(CMAKE) -E rm -R -f build