Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] MediaStore Support #68

Merged
merged 19 commits into from
Oct 11, 2024
Merged

[Android] MediaStore Support #68

merged 19 commits into from
Oct 11, 2024

Conversation

ian-wd
Copy link

@ian-wd ian-wd commented Oct 7, 2024 •
edited
Loading

Added MediaStore support for android

  • Only supports API lvl 29 and higher

Inspired by https://github.com/RonRadtke/react-native-blob-util/wiki/MediaStore/

@ian-wd ian-wd changed the title Media Store Support [Android] MediaStore Support Oct 7, 2024
iBotPeaches
iBotPeaches reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this code is shorthand. Can we swap to {} for all if/else/etc? Its tough to read for me with all this fancy single liners.

src/types.ts Outdated Show resolved Hide resolved
example/App/example3.tsx Outdated Show resolved Hide resolved
example/App/example3.tsx Outdated Show resolved Hide resolved
example/App/example3.tsx Outdated Show resolved Hide resolved
example/App/example3.tsx Outdated Show resolved Hide resolved
@iBotPeaches iBotPeaches merged commit ac08362 into master Oct 11, 2024
1 check passed
@iBotPeaches iBotPeaches deleted the RNFS-MediaStore branch October 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemanjar7 nemanjar7 nemanjar7 approved these changes

@jyann jyann jyann approved these changes

@iBotPeaches iBotPeaches iBotPeaches approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ian-wd @iBotPeaches @jyann @nemanjar7