A few improvement ideas #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
lint-ideas
branch
2 times, most recently
from
88afb18
to
e5abdf0
Compare
kornelski
reviewed
Mar 31, 2024
.github/workflows/rust.yml
Outdated
| run: cargo test --verbose | ||
| - uses: actions/checkout@v2 | ||
| - name: Ensure proper formatting (use `cargo fmt` to fix) | ||
| run: cargo fmt --all -- --check |
There was a problem hiding this comment.
Please don't force formatting. Rustfmt is not good enough to apply unconditionally, and it's a bad experience for people submitting PRs to have them rejected only due to a space or something trivial that could be fixed afterwards.
I was reviewing code, and just made a bunch of minor fixes. I wasn't sure where you want to take this code next, so its one PR - but I could remove any parts that you think are not improving. * Fix README crates link to point to crates.io, and add a few more status tags. * Migrate to 2021 edition * A few `cargo fmt` and `cargo clippy` changes * Use cm::Ordering to do the compare+match * A few minor CI improvements to catch those * Move main example to README.md, and made README.md included into the code as documentation - this way both GitHub and cargo.rs should the same documentation. * Make README examples runnable/testable (now part of `cargo test`) * I am not sure homepage should link to lib.rs -- perhaps consider removing it?
|
thx, updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing code, and just made a bunch of minor fixes. I wasn't sure where you want to take this code next, so its one PR - but I could remove any parts that you think are not improving.
cargo fmtandcargo clippychangescargo test)TODO