-
Notifications
You must be signed in to change notification settings - Fork 45
Giving some love to Spot instances #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fb4c28 to
58bb5de
Compare
|
|
||
| ### Graceful Spot Instance Interruption Handling | ||
|
|
||
| The Spacelift worker includes built-in spot instance interruption detection to minimize job disruption: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a recent development in the worker code that I did last night. I'm still testing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: peterdeme <[email protected]>
58bb5de to
2ea3b0b
Compare
TheOutdoorProgrammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just the example and docs? where is the rest?
|
@Apollorion there is no rest, this is just documentation. we were always compatible with spot, we just never really recommended them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Description of the change
I have looked into our launcher/worker code recently and I have noticed that it'd quite easy to detect Spot Instance interruption signals, so I implemented a graceful shutdown behavior in our code.
I thought I'll explicitly mention some details in our TF module as well. If it functions as I expect it to, I'll extend our official documentation as well.
edit: I was able to test it and it works :)
Type of change
Checklists
Development
Code review