Skip to content

Conversation

@adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Aug 28, 2025

Description of the change

I've updated the startup script to check whether it's connecting to the MQTT broker for our FedRAMP environment. If so it downloads the FedRAMP-specific version of the launcher.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@adamconnelly adamconnelly requested a review from a team as a code owner August 28, 2025 11:35
@adamconnelly adamconnelly requested a review from a team August 28, 2025 11:35
@adamconnelly adamconnelly force-pushed the adamc/CU-869a3q1vh-fedramp-launcher-binary branch from 318b19c to 6c00faa Compare August 28, 2025 11:36
frncmx
frncmx previously approved these changes Aug 28, 2025
jmfontaine
jmfontaine previously approved these changes Aug 28, 2025
Copy link
Contributor

@jmfontaine jmfontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamconnelly adamconnelly dismissed stale reviews from jmfontaine and frncmx via 5dc6a93 August 28, 2025 16:26
@adamconnelly adamconnelly force-pushed the adamc/CU-869a3q1vh-fedramp-launcher-binary branch from 6c00faa to 5dc6a93 Compare August 28, 2025 16:26
@adamconnelly adamconnelly changed the title feat: add a new setting for the FedRAMP environment feat: download correct binary when in FedRAMP environment Aug 28, 2025
@adamconnelly adamconnelly force-pushed the adamc/CU-869a3q1vh-fedramp-launcher-binary branch from 5dc6a93 to 80bc424 Compare August 28, 2025 16:27
I've updated the startup script to check whether it's connecting to the MQTT broker for our FedRAMP environment. If so it downloads the FedRAMP-specific version of the launcher.
@adamconnelly adamconnelly force-pushed the adamc/CU-869a3q1vh-fedramp-launcher-binary branch from 80bc424 to e7db9a5 Compare August 28, 2025 16:28
@adamconnelly
Copy link
Contributor Author

@jmfontaine @Apollorion @frncmx I've updated this to be a bit simpler based on Joey's suggestion. Instead of a new var, I'm just looking at the MQTT broker hostname to decide which binary to download. This means it'll just work seamlessly for customers with no extra configuration for FedRAMP.

Apologies that I squashed all the changes instead of pushing separate commits - I just did it by accident without thinking.

Copy link
Contributor

@frncmx frncmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies that I squashed all the changes instead of pushing separate commits - I just did it by accident without thinking.

I still read less, than before. 😆

lgtm; like

Copy link
Member

@TheOutdoorProgrammer TheOutdoorProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamconnelly adamconnelly merged commit 29684b1 into main Aug 29, 2025
14 checks passed
@adamconnelly adamconnelly deleted the adamc/CU-869a3q1vh-fedramp-launcher-binary branch August 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants