-
Notifications
You must be signed in to change notification settings - Fork 45
feat: download correct binary when in FedRAMP environment #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
318b19c to
6c00faa
Compare
jmfontaine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6c00faa to
5dc6a93
Compare
5dc6a93 to
80bc424
Compare
I've updated the startup script to check whether it's connecting to the MQTT broker for our FedRAMP environment. If so it downloads the FedRAMP-specific version of the launcher.
80bc424 to
e7db9a5
Compare
|
@jmfontaine @Apollorion @frncmx I've updated this to be a bit simpler based on Joey's suggestion. Instead of a new var, I'm just looking at the MQTT broker hostname to decide which binary to download. This means it'll just work seamlessly for customers with no extra configuration for FedRAMP. Apologies that I squashed all the changes instead of pushing separate commits - I just did it by accident without thinking. |
frncmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies that I squashed all the changes instead of pushing separate commits - I just did it by accident without thinking.
I still read less, than before. 😆
lgtm; like
TheOutdoorProgrammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description of the change
I've updated the startup script to check whether it's connecting to the MQTT broker for our FedRAMP environment. If so it downloads the FedRAMP-specific version of the launcher.
Type of change
Checklists
Development
Code review