Skip to content

Conversation

@oscartospacelift
Copy link
Contributor

…d builds.

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

adamconnelly
adamconnelly previously approved these changes Sep 5, 2025
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Have you been able to test this "locally" @oscartospacelift? If not let me know and I can do a quick sanity check before you merge it / I can give you pointers on how to test the changes if you need them.

@oscartospacelift
Copy link
Contributor Author

I did not test it.

It would be nice to know how to, yeah :)

Copy link
Contributor

@frncmx frncmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm; minor comments

@oscartospacelift oscartospacelift merged commit a01a4df into main Sep 9, 2025
13 of 14 checks passed
@oscartospacelift oscartospacelift deleted the CU-8699yp7ej_enableFIPS branch September 9, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants