Skip to content

feat(env-vars): Add description field to Terraform spacelift_environment_variable resource #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

0michalsokolowski0
Copy link
Contributor

@0michalsokolowski0 0michalsokolowski0 commented Aug 12, 2024

Description of the change

Adding a new optional field to spacelift_environment_variable Terraform module called description, more details.

image
image

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@0michalsokolowski0 0michalsokolowski0 changed the title feat(api-keys): Initial implementation feat(api-keys): Add description field to Terraform spacelift_environment_variable resource Aug 12, 2024
@0michalsokolowski0 0michalsokolowski0 marked this pull request as ready for review August 12, 2024 13:04
@0michalsokolowski0 0michalsokolowski0 changed the title feat(api-keys): Add description field to Terraform spacelift_environment_variable resource feat(env-vars): Add description field to Terraform spacelift_environment_variable resource Aug 12, 2024
@0michalsokolowski0 0michalsokolowski0 force-pushed the CU-8695950mj-add-description-to-tf-spacelift_environment_variable-resource branch from 554d98d to 6ef7b87 Compare August 13, 2024 07:47
Copy link
Contributor

@mbialon mbialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@tomasmik tomasmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@0michalsokolowski0 0michalsokolowski0 merged commit dee0f60 into main Aug 14, 2024
7 checks passed
@0michalsokolowski0 0michalsokolowski0 deleted the CU-8695950mj-add-description-to-tf-spacelift_environment_variable-resource branch August 14, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants