Add non-sensitive value attribute to environment variable resource #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbialon
force-pushed
the
mbialon/push-ztlskooqqpnp
branch
4 times, most recently
from
21d2364 to
d58db12
Compare
This change adds an alternative, non-sensitive `value` attribute to the environment variable resource. This allows users to view the value of non-sensitive environment variables. As I can't see the reason to have write-only, non-sensitive values, this combination is not allowed. Fixes #517
mbialon
force-pushed
the
mbialon/push-ztlskooqqpnp
branch
from
d58db12 to
d7a26f9
Compare
mbialon
changed the title
eliecharra
reviewed
Sep 12, 2025
| ForceNew: true, | ||
| ConflictsWith: []string{"value_nonsensitive"}, | ||
| }, | ||
| "value_nonsensitive": { |
Member
There was a problem hiding this comment.
If we introduce that, we should IMO fully get rid of write_only since it will bring confusion.
The validation we perform works, but will only trigger during apply I think nope? That's a bit sad that we can't catch such misconfiguration earlier in the plan.
Removing write_only will introduce a BC break, so I can understand we want to avoid that. But maybe let's mark it as deprecated?
Can we also use ConflictsWith write_only ? Or find a way to validate that the logic is correct earlier than during apply? Not sure if we can do cross field validation 🤔
sephriot
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change adds an alternative, non-sensitive
valueattribute to the environment variable resource.This allows users to view the value of non-sensitive environment variables.
As I can't see the reason to have write-only, non-sensitive values, this combination is not allowed.
Type of change
Related issues
Fixes #517
Checklists
Development
false.)go generateto make sure the docs are up to dateCode review