steps should be discrete offsets from lowerBound #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
Apple's
Slider()
reports the discrete values [ 1, 3, 5, 7, 9 ] whileValueSlider()
reports [ 1, 2, 4, 6, 8, 10 ]. IOW,Slider()
's steps are offsets from thelowerBound
whileValueSlider()
's are 0-based.This PR changes the behavior of
step
to matchSlider()
.Note: even with this fix,
ValueSlider()
will report [ 1, 3, 5, 7, 9, 10 ] even though theupperBound
value is not a multiple ofstep
. That's easily worked around by client code if desired, so I'm not sure it should be fixed.