Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux VM spectrum viewer problem to known bugs #1475

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Jul 11, 2022

Does what it says on the tin. This is the workaround for glue-viz/bqplot-image-gl#94.

@github-actions github-actions bot added the documentation Explanation of code and concepts label Jul 11, 2022
Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc build renders and the entry succinctly explains the problem and work around. Thanks!

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1475 (19827aa) into main (aec90f1) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   85.38%   85.41%   +0.03%     
==========================================
  Files          91       91              
  Lines        8476     8483       +7     
==========================================
+ Hits         7237     7246       +9     
+ Misses       1239     1237       -2     
Impacted Files Coverage Δ
jdaviz/configs/cubeviz/plugins/viewers.py 88.88% <0.00%> (+0.11%) ⬆️
jdaviz/configs/cubeviz/plugins/parsers.py 56.57% <0.00%> (+0.28%) ⬆️
jdaviz/configs/cubeviz/helper.py 88.00% <0.00%> (+0.76%) ⬆️
jdaviz/configs/imviz/plugins/tools.py 84.49% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec90f1...19827aa. Read the comment docs.

@pllim pllim added this to the 2.8 milestone Jul 11, 2022
docs/known_bugs.rst Outdated Show resolved Hide resolved
docs/known_bugs.rst Outdated Show resolved Hide resolved
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

When running Jdaviz on a virtual Linux machine, the spectrum may not appear
in the spectrum viewer. This is a known bug in an underlying package. Until
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to that issue upstream?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, I just didn't think the average user would care.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more for the dev later on to see if the bug is still relevant.

docs/known_bugs.rst Outdated Show resolved Hide resolved
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

When running Jdaviz on a Linux virtual machine (VM), the spectrum may not appear
in the spectrum viewer. This is a `known bug <known-gl-issue>` in an underlying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is known-gl-issue defined? I don't see it in the diff here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ffs, I had the wrong text in my clipboard when I pasted

Apply suggestions from code review

Co-authored-by: P. L. Lim <[email protected]>

Add link to external issue

Fix link and squash
docs/known_bugs.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM though I think you need a trailing underscore for the link to render properly?

@rosteen rosteen merged commit 0974027 into spacetelescope:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive specviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants