-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux VM spectrum viewer problem to known bugs #1475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc build renders and the entry succinctly explains the problem and work around. Thanks!
Codecov Report
@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
+ Coverage 85.38% 85.41% +0.03%
==========================================
Files 91 91
Lines 8476 8483 +7
==========================================
+ Hits 7237 7246 +9
+ Misses 1239 1237 -2
Continue to review full report at Codecov.
|
docs/known_bugs.rst
Outdated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
When running Jdaviz on a virtual Linux machine, the spectrum may not appear | ||
in the spectrum viewer. This is a known bug in an underlying package. Until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to that issue upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, I just didn't think the average user would care.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more for the dev later on to see if the bug is still relevant.
docs/known_bugs.rst
Outdated
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
When running Jdaviz on a Linux virtual machine (VM), the spectrum may not appear | ||
in the spectrum viewer. This is a `known bug <known-gl-issue>` in an underlying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is known-gl-issue
defined? I don't see it in the diff here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ffs, I had the wrong text in my clipboard when I pasted
Apply suggestions from code review Co-authored-by: P. L. Lim <[email protected]> Add link to external issue Fix link and squash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM though I think you need a trailing underscore for the link to render properly?
Co-authored-by: P. L. Lim <[email protected]>
Does what it says on the tin. This is the workaround for glue-viz/bqplot-image-gl#94.