Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix devdeps job #2572

Merged
merged 3 commits into from
Jan 9, 2024
Merged

TST: Fix devdeps job #2572

merged 3 commits into from
Jan 9, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 21, 2023

We are letting real bugs through waiting on shapely to acknowledge numpy 2.0, so I think it is less risky to disable numpy-dev for now so we can test dev versions of the rest.


TST: Add pyerfa-dev to devdeps and remove unnecessary tox requirements.

BLD: No longer need to specify wheel in build requirements.

xref astropy/astropy#15638

Blocked by

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Nov 21, 2023
@pllim pllim added this to the 3.8 milestone Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (410d2f2) 91.53% compared to head (64440de) 91.53%.

❗ Current head 64440de differs from pull request most recent head 1ff23c4. Consider uploading reports for the commit 1ff23c4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2572   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         161      161           
  Lines       20062    20056    -6     
=======================================
- Hits        18363    18358    -5     
+ Misses       1699     1698    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2023

Tsk tsk, need to wait for scikit-image. Same problem as spacetelescope/acstools#192

@pllim
Copy link
Contributor Author

pllim commented Dec 13, 2023

Gah, now it is shapely. Do we really need this, @astrofrog ?

glue/core/data_factories/helpers.py:30: in <module>
    from glue.core.component import CoordinateComponent
glue/core/component.py:5: in <module>
    import shapely
shapely/__init__.py:1: in <module>
    from shapely.lib import GEOSException  # NOQA
E   ImportError: numpy.core.multiarray failed to import

and remove unnecessary tox requirements.

BLD: No longer need to specify wheel in build requirements.
@pllim
Copy link
Contributor Author

pllim commented Jan 8, 2024

Let's disable numpy-dev for now. When this is merged, I can open follow-up issue. Did fix a real test bug. I think this is ready for review/merge. Thanks!

@pllim
Copy link
Contributor Author

pllim commented Jan 9, 2024

@kecnry , so did you approve?

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok by me as long as we re-introduce testing numpy dev once upstream blockers are removed. Thanks!

@pllim pllim merged commit d91877a into spacetelescope:main Jan 9, 2024
13 checks passed
@pllim pllim deleted the fix-devdeps branch January 9, 2024 20:54
@pllim
Copy link
Contributor Author

pllim commented Jan 9, 2024

Opened follow-up issue at #2659 . Thanks!

@pllim
Copy link
Contributor Author

pllim commented Feb 5, 2024

@meeseeksdev backport to v3.8.x

meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Feb 5, 2024
@pllim pllim modified the milestones: 3.9, 3.8.2 Feb 5, 2024
@pllim pllim added the 💤backport-v3.8.x on-merge: backport to v3.8.x label Feb 5, 2024
pllim added a commit that referenced this pull request Feb 5, 2024
…2-on-v3.8.x

Backport PR #2572 on branch v3.8.x (TST: Fix devdeps job)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two Upstream fix required 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants