-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Fix devdeps job #2572
TST: Fix devdeps job #2572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 161 161
Lines 20062 20056 -6
=======================================
- Hits 18363 18358 -5
+ Misses 1699 1698 -1 ☔ View full report in Codecov by Sentry. |
Tsk tsk, need to wait for scikit-image. Same problem as spacetelescope/acstools#192 |
Gah, now it is shapely. Do we really need this, @astrofrog ?
|
and remove unnecessary tox requirements. BLD: No longer need to specify wheel in build requirements.
Let's disable numpy-dev for now. When this is merged, I can open follow-up issue. Did fix a real test bug. I think this is ready for review/merge. Thanks! |
@kecnry , so did you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok by me as long as we re-introduce testing numpy dev once upstream blockers are removed. Thanks!
Opened follow-up issue at #2659 . Thanks! |
@meeseeksdev backport to v3.8.x |
…2-on-v3.8.x Backport PR #2572 on branch v3.8.x (TST: Fix devdeps job)
We are letting real bugs through waiting on shapely to acknowledge numpy 2.0, so I think it is less risky to disable numpy-dev for now so we can test dev versions of the rest.
TST: Add pyerfa-dev to devdeps and remove unnecessary tox requirements.
BLD: No longer need to specify wheel in build requirements.
xref astropy/astropy#15638
Blocked by
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.