Skip to content

Conversation

@kecnry
Copy link
Member

@kecnry kecnry commented Feb 24, 2025

Description

This pull request shows a POC of how a plugin subcomponent (i.e. table) can be shown in the golden-layout of the main app/viewer section of the app. This was an old POC rebased onto main so that we can discuss if we want to polish it for use with catalogs tables or wait for a fully-fledged table viewer (cc @bmorris3 )

Screen.Recording.2025-02-24.at.1.43.15.PM.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.2 milestone Feb 24, 2025
@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Feb 24, 2025
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to remove the table from the plugin when it has been popped out, and show it again in the plugin when the in-app table is closed?

@kecnry
Copy link
Member Author

kecnry commented Mar 6, 2025

Would it be possible to remove the table from the plugin when it has been popped out, and show it again in the plugin when the in-app table is closed?

Probably - but we'd also probably only want to do that for the tray instance (not any in-line or popout instances of plugins), right?

@kecnry kecnry force-pushed the plugin-subcomponent-in-app branch from 8ace6bc to 14c70db Compare March 6, 2025 17:05
@rosteen rosteen modified the milestones: 4.2, 4.3 Mar 17, 2025
@rosteen rosteen modified the milestones: 4.3, 4.4 Jul 28, 2025
@rosteen rosteen modified the milestones: 4.4, 4.5 Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

embed Regarding issues with front-end embedding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants