Skip to content

Conversation

@mariobuikhuizen
Copy link
Collaborator

Description

This pull request adds support for changing layer order with drag and drop.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?
Screen.Recording.2025-04-08.at.14.58.54.mov

@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Apr 8, 2025
@mariobuikhuizen mariobuikhuizen force-pushed the feat_drag_drop_layers branch from 5d0a509 to 366991e Compare April 8, 2025 13:10
@mariobuikhuizen
Copy link
Collaborator Author

mariobuikhuizen commented Apr 8, 2025

I just found out drag and drop doesn't work in the popout. I'm working on this. [fixed]

@mariobuikhuizen mariobuikhuizen force-pushed the feat_drag_drop_layers branch from 366991e to 5f2190e Compare April 8, 2025 14:31
@kecnry kecnry added this to the 4.3 milestone Apr 8, 2025
@kecnry kecnry force-pushed the feat_drag_drop_layers branch from 1c70271 to 85cd7b6 Compare May 8, 2025 15:06
@kecnry
Copy link
Member

kecnry commented May 8, 2025

I merged main into this to get it up-to-date but am still having some issues where I don't see the actual viewer update. We'll also need to update the logic in get_active_image_layer so both the mouseover coordinates and #3514 can handle layer ordering by z-order rather than the order in the list (or alternatively, could/should this just update the layers list order directly?).

@rosteen rosteen modified the milestones: 4.3, 4.4 Jul 28, 2025
@kecnry
Copy link
Member

kecnry commented Sep 16, 2025

this now seems to be working for me after another rebase 🎉 . We'll need to update the mouseover logic yet before merge, but can handle that on our end

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.52%. Comparing base (7c1bf61) to head (1297c50).

Files with missing lines Patch % Lines
...viz/configs/default/plugins/data_menu/data_menu.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3532   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files         180      180           
  Lines       24706    24719   +13     
=======================================
+ Hits        21377    21389   +12     
- Misses       3329     3330    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rosteen rosteen modified the milestones: 4.4, 4.5 Sep 18, 2025
Codestyle

Fix bad rebase

Better fix for subset deletion handling
@rosteen rosteen force-pushed the feat_drag_drop_layers branch from 5f169b8 to 3509062 Compare October 7, 2025 20:07
@rosteen
Copy link
Collaborator

rosteen commented Oct 7, 2025

I pushed a couple commits here today to get subset deletion working (the layer was not properly disappearing from the data menu after the subset was deleted) and to get the mouseover coordinates to correctly pick up the top layer after drag and drop changes. There is one outstanding bug where occasionally the viewer will update but the layer dragged to the top will end up second from top in the data menu. Dragging it again puts it at the top of the data menu as intended:

Screen.Recording.2025-10-07.at.4.25.24.PM.mov

@javerbukh
Copy link
Contributor

javerbukh commented Oct 21, 2025

Both of the CI failures will be fixed once glue-jupyter releases with this PR glue-viz/glue-jupyter#493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Label for plugins common to multiple configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants