-
Notifications
You must be signed in to change notification settings - Fork 88
feat: use drag and drop to change layer order #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: use drag and drop to change layer order #3532
Conversation
5d0a509 to
366991e
Compare
|
I just found out drag and drop doesn't work in the popout. I'm working on this. [fixed] |
366991e to
5f2190e
Compare
1c70271 to
85cd7b6
Compare
|
I merged main into this to get it up-to-date but am still having some issues where I don't see the actual viewer update. We'll also need to update the logic in get_active_image_layer so both the mouseover coordinates and #3514 can handle layer ordering by z-order rather than the order in the list (or alternatively, could/should this just update the layers list order directly?). |
|
this now seems to be working for me after another rebase 🎉 . We'll need to update the mouseover logic yet before merge, but can handle that on our end |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3532 +/- ##
=======================================
Coverage 86.52% 86.52%
=======================================
Files 180 180
Lines 24706 24719 +13
=======================================
+ Hits 21377 21389 +12
- Misses 3329 3330 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codestyle Fix bad rebase Better fix for subset deletion handling
5f169b8 to
3509062
Compare
|
I pushed a couple commits here today to get subset deletion working (the layer was not properly disappearing from the data menu after the subset was deleted) and to get the mouseover coordinates to correctly pick up the top layer after drag and drop changes. There is one outstanding bug where occasionally the viewer will update but the layer dragged to the top will end up second from top in the data menu. Dragging it again puts it at the top of the data menu as intended: Screen.Recording.2025-10-07.at.4.25.24.PM.mov |
|
Both of the CI failures will be fixed once glue-jupyter releases with this PR glue-viz/glue-jupyter#493 |
Description
This pull request adds support for changing layer order with drag and drop.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.Screen.Recording.2025-04-08.at.14.58.54.mov