Skip to content

Conversation

@maartenbreddels
Copy link
Collaborator

Description

This tests if cubeviz in standalone mode works.
It should currently fail, since it requires:
glue-viz/glue#2536

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

It should currently fail, since it requires:
 glue-viz/glue#2536
@maartenbreddels maartenbreddels added the Build standalone Additional pylons label Apr 29, 2025
@maartenbreddels maartenbreddels force-pushed the test_standalone_cubeviz branch from 8f5c5b8 to 6ba994a Compare April 29, 2025 13:41
@maartenbreddels maartenbreddels removed the Build standalone Additional pylons label Apr 29, 2025
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Apr 29, 2025
@kecnry kecnry added this to the 4.3 milestone Apr 29, 2025
@kecnry
Copy link
Member

kecnry commented Jun 13, 2025

looks like there has been a glue release since that upstream PR was merged - can we update the requirements and revive this?

@rosteen rosteen modified the milestones: 4.3, 4.4 Jul 28, 2025
@rosteen rosteen modified the milestones: 4.4, 4.5 Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed changelog bot directive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants