Skip to content

Conversation

@kecnry
Copy link
Member

@kecnry kecnry commented Jul 21, 2025

Description

This pull request changes the behavior of the VO plugin to not update the coords when the link type changes (unless manually requested or the auto-switch is enabled).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • If new remote data is added that uses MAST, is the URI added to the cache-download.yml workflow?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

(unless coord_follow_viewer_pan is True, in which case existing callbacks on viewer limits should trigger)
@kecnry kecnry added this to the 4.3 milestone Jul 21, 2025
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jul 21, 2025
@rosteen rosteen modified the milestones: 4.3, 4.4 Jul 28, 2025
@rosteen rosteen modified the milestones: 4.4, 4.5 Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Label for plugins common to multiple configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants