Support to export via serverside or clientside #3789
Draft
+142
−87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request integrates the solara
FileDownloadwidget to support saving any exported file via the browsers Save dialog in addition to the existing support to save python/server-side. In doing so, this removes the previousshow_dialogkwarg which was only supported for png files.Deployments in which the server is private should continue to set
serverside_enabled = Falseto disable access to saving files on that machine, in which case only the new widget will be shown.This is currently a WIP as there are still some bugs, including a double file-dialog when downloading images from viewers and some issues in saving subsets as regions, etc.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?