Fix Roman ASDF spectrum loading in Specviz #3823
Draft
+200
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
specviz
plugin
kecnry
reviewed
Oct 7, 2025
Comment on lines
-423
to
+426
| and not any([format in (fmt_item['label'], | ||
| fmt_item['parser'], | ||
| fmt_item['importer']) | ||
| for format in formats])): | ||
| and not any([fmt in (fmt_item['label'], | ||
| fmt_item['parser'], | ||
| fmt_item['importer']) | ||
| for fmt in formats])): |
There was a problem hiding this comment.
good catch! This would be great as a separate bugfix PR if possible!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made specviz compatible with Roman ASDF, specifically "wfi_spec_individual_1d_r0000201001001001001_0002_WFI01.asdf"