Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two bugs that have been found related to the orientation plugin
self.rotation_anglewith the orientation plugin when a new orientation is set. This wasn't being done before, and thus aida was unable to determine the orientation of imviz properly.Default Orientationto ensure that the least number of updates is needed for the new orientation. This adds a slight lag to adding new orientations for orientations < 4 but significantly reduces lag when any more orientations are created.Note: still outstanding is the issue of setting
self.rotation_anglewhen the orientation is changed to an existing orientation. That will need to be addressed in a separate PR once a root cause is determinedChange log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?