Skip to content

Conversation

@rosteen
Copy link
Collaborator

@rosteen rosteen commented Oct 22, 2025

I need to add a CI test but this is ready for testing.

@rosteen rosteen added this to the 4.5 milestone Oct 22, 2025
@rosteen rosteen added the plugin Label for plugins common to multiple configurations label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.62%. Comparing base (fbcabce) to head (5228ce7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nfigs/default/plugins/subset_tools/subset_tools.py 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3853      +/-   ##
==========================================
- Coverage   87.63%   87.62%   -0.01%     
==========================================
  Files         188      188              
  Lines       25703    25707       +4     
==========================================
+ Hits        22524    22527       +3     
- Misses       3179     3180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this either share or copy the behavior from plugin_editable_select for consistency (and so there can be confirmation and API hints)?

Copy link
Contributor

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works well!

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!

@rosteen
Copy link
Collaborator Author

rosteen commented Oct 24, 2025

Can this either share or copy the behavior from plugin_editable_select for consistency (and so there can be confirmation and API hints)?

Personally I don't really like confirmation for the delete button - renaming needs it because otherwise the app won't know when you're done typing, but for deletion it's just an unnecessary extra button click, IMO. I guess that means there's nowhere/no time to display an API hint in the UI 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Label for plugins common to multiple configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants