-
Notifications
You must be signed in to change notification settings - Fork 88
Add ability to delete subsets from Subset Tools plugin and API #3853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3853 +/- ##
==========================================
- Coverage 87.63% 87.62% -0.01%
==========================================
Files 188 188
Lines 25703 25707 +4
==========================================
+ Hits 22524 22527 +3
- Misses 3179 3180 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this either share or copy the behavior from plugin_editable_select for consistency (and so there can be confirmation and API hints)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and works well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple!
Personally I don't really like confirmation for the delete button - renaming needs it because otherwise the app won't know when you're done typing, but for deletion it's just an unnecessary extra button click, IMO. I guess that means there's nowhere/no time to display an API hint in the UI 🤔 |
I need to add a CI test but this is ready for testing.