Skip to content

Conversation

@cshanahan1
Copy link
Contributor

@cshanahan1 cshanahan1 commented Oct 23, 2025

(this is on top of 3854 which is on top of #3835, so just look at the last commit for the diff isolated to this PR)

Adds a required source ID column to source catalogs. If no catalog is selected, the index of each source in the table is used as its ID. This ID is displayed in the mouseover info for the catalog.

I also added a few small changes including having a column non-selection be closer to the top of the list (for example, if a X/Y col was auto detected but you don't want to load it, the --- option was at the bottom of the list before so it wasn't super clear that you could choose NOT to load this column. I moved it to the second entry so its at the top of the list. I also added a few more column name matches when guessing RA/Dec/X/Y so that you can export a markers table and load it back in as a source catalog seamlessly.

@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Oct 23, 2025
@cshanahan1 cshanahan1 changed the title Catalog id column Add source catalog source id column, use for mouseover Oct 23, 2025
@cshanahan1 cshanahan1 added this to the 4.5 milestone Oct 24, 2025
@cshanahan1 cshanahan1 added the no-changelog-entry-needed changelog bot directive label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 85.33333% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.60%. Comparing base (f300cd7) to head (8c265bf).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/core/loaders/importers/catalog/catalog.py 91.12% 11 Missing ⚠️
...z/configs/imviz/plugins/orientation/orientation.py 33.33% 10 Missing ⚠️
...viz/configs/default/plugins/data_menu/data_menu.py 83.33% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (85.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3856      +/-   ##
==========================================
- Coverage   87.63%   87.60%   -0.04%     
==========================================
  Files         188      188              
  Lines       25703    25783      +80     
==========================================
+ Hits        22524    22586      +62     
- Misses       3179     3197      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

row1a_text = ''
row1a_title = ''
row1a_text = str(image.data['ID'][cur_i])
row1a_title = 'Source ID'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can/should this use the original name of the column? Maybe since this is only used for mouseover and not any linking, we could just store the column name in the metadata rather than having to hardcode a label (and just avoid duplications if its also listed in other columns)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants