-
Notifications
You must be signed in to change notification settings - Fork 88
Add source catalog source id column, use for mouseover #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bbf815a to
6c191a9
Compare
6c191a9 to
8c265bf
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (85.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3856 +/- ##
==========================================
- Coverage 87.63% 87.60% -0.04%
==========================================
Files 188 188
Lines 25703 25783 +80
==========================================
+ Hits 22524 22586 +62
- Misses 3179 3197 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| row1a_text = '' | ||
| row1a_title = '' | ||
| row1a_text = str(image.data['ID'][cur_i]) | ||
| row1a_title = 'Source ID' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can/should this use the original name of the column? Maybe since this is only used for mouseover and not any linking, we could just store the column name in the metadata rather than having to hardcode a label (and just avoid duplications if its also listed in other columns)?
(this is on top of 3854 which is on top of #3835, so just look at the last commit for the diff isolated to this PR)
Adds a required source ID column to source catalogs. If no catalog is selected, the index of each source in the table is used as its ID. This ID is displayed in the mouseover info for the catalog.
I also added a few small changes including having a column non-selection be closer to the top of the list (for example, if a X/Y col was auto detected but you don't want to load it, the --- option was at the bottom of the list before so it wasn't super clear that you could choose NOT to load this column. I moved it to the second entry so its at the top of the list. I also added a few more column name matches when guessing RA/Dec/X/Y so that you can export a markers table and load it back in as a source catalog seamlessly.