TST: See if percentile is breaking devdeps (try 2) #96
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -15,7 +15,8 @@ | |||
| from jdaviz.configs.default.plugins.viewers import JdavizViewerMixin | |||
| from jdaviz.configs.specviz.plugins.viewers import SpecvizProfileView | |||
|
|
|||
| from lcviz.state import ScatterViewerState | |||
| #from lcviz.state import ScatterViewerState | |||
| from glue.viewers.scatter.state import ScatterViewerState | |||
There was a problem hiding this comment.
This is what actually fixed the failures, so I convinced myself now that the incompatibility is within lcviz and not jdaviz. However, in doing this, some results in test_plugin_markers.py changed and I am not sure why.
There was a problem hiding this comment.
we want the lcviz overrides for resetting limits though. But something in there must not be playing nicely with the upstream PR in jdaviz that introduced the zoom-radius for Imviz 🤔
There was a problem hiding this comment.
Yeah, pretty much. There is nothing to do over at Jdaviz for this.
There was a problem hiding this comment.
I am not 100% sure that is the case yet, we still need to understand why ScatterViewerState in lcviz is conflicting with the logic from spacetelescope/jdaviz#2649. The fix may be here or something may need to be generalized there more, I'm not sure yet. But I think we can now be fairly certain that the configs in jdaviz are not affected
There was a problem hiding this comment.
I am not sure if I am the best person to investigate more. I never worked on lcviz so I am not privy on what your scatter state customization is supposed to do.
Builds on top of #68 to investigate #93 . Supersedes #95 .