-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add allow_failure #26
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 4 4
Lines 61 61
=======================================
Hits 59 59
Misses 2 2 Continue to review full report at Codecov.
|
For this particular case, why not set fail-fast to |
There is no true "allow to fail" in Actions. That is, it will still show up as ❌ , it just won't stop other jobs from running. |
In the case of spacetelescope/jdaviz#369 I was thinking there was one build that sometimes fails but I wanted all the other ones to have the "fail fast" behavior. (you pointed out the fix for that @pllim, so that particular build is now fixed, but the idea of having a way to indicate one of the builds should be allowed to fail is the intent here).
We could change the wording because I agree it's not quite the same as in travis. But it looks to me like at least treating the whole build as ok, because if I go to https://github.com/eteq/jdaviz/actions and scroll down to #6, there's a green check next to it even though when you go into https://github.com/eteq/jdaviz/actions/runs/373116419 you see that it's got the red X. |
Ah, okay. Perhaps add some comments to explain your intent here, and maybe even comment them out for now? I am worried that people use this blindly and then resulting in running extra jobs unnecessarily when some of the jobs fail. That is, what they really need is "fail fast" but they are getting "run them all" from the template by default. |
This PR makes a small change inspired by spacetelescope/jdaviz#369 - there I had a build I wanted to be an "Allowed failure" a la the Travis option. This PR does that using the continue-on-error github action option