Skip to content

notary: Use separate input and output directories #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scottwittenburg
Copy link
Collaborator

@scottwittenburg scottwittenburg commented Apr 9, 2025

After content-addressable tarballs is merged, clearsigning will be performed on spec manifest files, without changing the name of the file. This change keeps the original file name when re-signing, and to prevent issues with gpg overwriting files, it puts re-signed files into a different directory from the original files.

This can be merged before the content-addressable tarballs spack PR.

@scottwittenburg
Copy link
Collaborator Author

The notary image appears to be the only one where we don't pinpoint a specific numeric version of the image to build and use, does anyone know if that was an oversight or was it deliberate?

@zackgalbreath
Copy link
Collaborator

The notary image appears to be the only one where we don't pinpoint a specific numeric version of the image to build and use, does anyone know if that was an oversight or was it deliberate?

FWIW, there's no discussion on #252 about why we did it this way at the time. At the very least, we are setting imagePullPolicy: "always" here.

Off the top of my head, I can't think of any reason why pinning the notary runner to a specific tag would be a bad idea.

@scottwittenburg
Copy link
Collaborator Author

Off the top of my head, I can't think of any reason why pinning the notary runner to a specific tag would be a bad idea.

Ok, I'll start that by specifying 0.0.1 in this PR.

After content-addressable tarballs is merged, clearsigning will be
performed on spec manifest files, without changing the name of the
file.  To prevent issues with gpg overwriting files, this change
puts re-signed files into a different directory from the original
files.
@scottwittenburg scottwittenburg force-pushed the fix-signing-for-content-addressed branch from 3c670ed to 7152074 Compare April 10, 2025 20:26
@zackgalbreath
Copy link
Collaborator

Noting for posterity that the lack of image bump in k8s/production/runners/signing/release.yaml is intentional.

@scottwittenburg scottwittenburg merged commit 906901a into spack:main Apr 10, 2025
14 of 15 checks passed
@scottwittenburg scottwittenburg deleted the fix-signing-for-content-addressed branch April 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants