sign.sh: Preserve package name subdirectories when signing #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we store specs in subdirectories named after the package, we need to preserve that structure when moving the files from the input directory to the verified directory, and again when moving them from the verified directory to the output directory.
zackgalbreath
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we store specs in subdirectories named after the package, we need to preserve that structure when moving the files from the input directory to the verified directory, and again when moving them from the verified directory to the output directory.
I think this should actually preserve whatever structure we find inside
/tmp/input/all the way through to the files we write to/tmp/output/, so if we decide to reorganize things again, we can hopefully avoid yet another change to this signing script.