Fix protected publish for v3 layout buildcaches #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the v3 version of protected publish to correctly look for manifests, generating the meta and archive urls from those.
|
Not sure it makes sense to update the image version in the migrate job, since we're not planning to update that for the newest v3 layout. |
21 tasks
zackgalbreath
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the v3 version of protected publish to correctly look for manifests, generating the meta and archive urls from those.
I tested this by publishing a single test stack (build_systems) to the root under both v2 and v3 layouts. We should be able to merge it now, and publishing v2 stacks to the root will continue to work. Once the content-addressable tarballs PR is merged to spack
develop, we will need a tiny PR to the cron job arguments to swtich from--version 2to--version 3.