Add precondition for expired gitlab token #836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
add-gl-token-expiration-check
branch
from
55c9560 to
e4c2fd1
Compare
jjnesbitt
reviewed
May 8, 2024
Comment on lines
+36
to
+41
| lifecycle { | ||
| precondition { | ||
| condition = timecmp(timestamp(), "${local.webhook_handler_token_expires_at}T00:00:00Z") == -1 | ||
| error_message = "The token has expired. Please update the expires_at date." | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This is great, although I'm concerned at what happens when encounter this expiration date. The terraform plan/apply will fail loudy about it, but besides that how would we know? Let's say if we haven't run terraform plan/apply for a while during the expiration date, would we just be relying on sentry at that point?
This is sort of secondary to this PR, which I think looks good itself, but just thought I'd raise this question.
jjnesbitt
approved these changes
May 8, 2024
Member
Author
|
Superseded by #1104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something useful I learned about Terraform recently. This will cause any plans or applys to fail if the token is expired.