Rework spack.database.InstallStatuses into a flag
#47321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
binary-packages
commands
core
haampie
reviewed
Oct 30, 2024
alalazo
commented
Nov 3, 2024
alalazo
force-pushed
the
maintainers/more-on-db-query
branch
from
a0dd35a
to
fd7a1f2
Compare
haampie
reviewed
Nov 5, 2024
haampie
reviewed
Nov 5, 2024
Also, don't use the built-in any as a sentinel, but create an appropriate value with flags.
Since the enum flag has been moved into a separate module, it makes sense to prefix it with "DB".
alalazo
force-pushed
the
maintainers/more-on-db-query
branch
from
47de62f
to
dddf1b0
Compare
haampie
reviewed
Nov 14, 2024
haampie
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
spack.databasewe use a custom enum-like classInstallStatusesfor legacy reasons1.In this PR we turn that class into an
enum.Flag, which has some small benefits:|. That allows us to simplify the signature of a couple of methodsanyfor that purposeOn top of that:
spack findthe--only-missingoption is mutually exclusive with--only-deprecated. Both can't be mixed with--missingand--deprecated.Footnotes
This class was added when Spack still had to support Python 2.6 ↩