Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When you associate a different service name for phoenix, the
phx.router_dispatch
has the default service name and not the custom one.The first commit allows to fix that by adding the span opts when the span for
phx.router_dispatch
is started.In case of an exception,
phx.router_dispatch
uses again the default service name:The second commit allows to fix that by adding the span opts when the span is finished:
We use this fix in prod and it works well.