#541 24년도 추석 이벤트 밴 미들웨어 #544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TaehyeonPark
changed the title
…541-24-chuseok-event-ban-middleware
Halo-sparcs
changed the title
kmc7468
requested changes
Apr 23, 2025
| @@ -17,6 +17,7 @@ import { | |||
| originValidatorMiddleware, | |||
| responseTimeMiddleware, | |||
| sessionMiddleware, | |||
| banMiddleware, | |||
There was a problem hiding this comment.
import를 지금 알파벳 순서로 맞춰놨는데, 요거에 맞춰주시면 좋을 것 같아요! (prettier에 import 자동 정렬을 넣으면 좋겠군요)
| @@ -78,14 +79,15 @@ app.use(limitRateMiddleware); | |||
| // [Router] Swagger (API 문서) | |||
| app.use("/docs", docsRouter); | |||
|
|
|||
| // [Middleware] 모든 API 요청에 대하여 origin 검증 | |||
There was a problem hiding this comment.
TS로 마이그레이션 완료되었으니 이 JS 파일은 삭제하면 될 것 같습니다.
| @@ -0,0 +1,37 @@ | |||
| import type { RequestHandler } from "express"; | |||
| import { eventStatusModel } from "../modules/stores/mongo"; | |||
| import logger from "../../modules/logger"; | |||
There was a problem hiding this comment.
이런 경우에는 @/modules/logger 로 간단하게 import할 수 있어요!
| * 사용자가 차단 되었는지 여부를 판단합니다. | ||
| * 차단된 사용자는 이벤트에 한하여 서비스 이용에 제재를 받습니다. | ||
| * | ||
| * @param req eventStatus가 성공적일 경우 req.eventStatus = eventStatus로 들어갑니다. |
| try { | ||
| // 이벤트(2025spring) 기간을 하루 더 연장하여 넙죽코인 소비기한을 보장할 때, completeQuest 함수를 비활성화합니다. | ||
| // 추후 이벤트에서는 아래 코드를 지워주시길 바랍니다. | ||
| if (timestamp >= new Date("2025-03-13T00:00:00+09:00")) return null; | ||
|
|
||
| // 1단계: 유저의 EventStatus를 가져옵니다. 블록드리스트인지도 확인합니다. | ||
| const eventStatus = await eventStatusModel.findOne({ userId }).lean(); | ||
| if (!eventStatus || eventStatus.isBanned) return null; | ||
|
|
||
| if (!eventStatus) return null; // |
| @@ -13,7 +13,8 @@ router.get( | |||
|
|
|||
| // 아래의 Endpoint 접근 시 로그인, 차단 여부 및 시각 체크 필요 | |||
| router.use(require("../../middlewares/auth").default); | |||
| router.use(require("../middlewares/checkBanned")); | |||
| router.use(require("../../middlewares/ban").default); | |||
There was a problem hiding this comment.
저희 ban 미들웨어가 index.ts 파일에 달려있어서, 이런 곳에선 use 안해주셔도 됩니다!
| @@ -15,7 +15,7 @@ const searchInviterHandler = async (req, res) => { | |||
| .lean(); | |||
| if ( | |||
| !inviterStatus || | |||
| inviterStatus.isBanned || | |||
| // !!banErrorMessage || | |||
Comment on lines
+36
to
+40
| session: { | ||
| loginInfo: { | ||
| sid: testUser1.id, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
이제 sid가 필요 없을 것 같은데, 이 부분은 삭제해도 될 것 같아요.
| import { validateServiceBanRecord } from "@/modules/ban"; | ||
|
|
||
| const serviceMapper = new Map([ | ||
| ["/rooms/create", "service"], | ||
| ["/rooms/join", "service"], | ||
| ["/rooms/create", "service"], // checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #541