+310
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
MinjaeKimmm
force-pushed
the
554-송금-독측-메일-관련-기능
branch
from
1fe55f6 to
92fd170
Compare
kmc7468
requested review from
Copilot,
kmc7468,
TaehyeonPark,
Halo-sparcs and
Mun09
and removed request for
kmc7468
There was a problem hiding this comment.
Pull Request Overview
This PR implements email tracking functionality for report-related emails in the taxi service system. It adds the ability to track when emails are opened by embedding a tracking pixel and storing tracking data in the database.
- Adds email open tracking with unique tracking IDs and database storage
- Implements a new email tracking endpoint for handling pixel requests
- Enhances error handling with Slack notifications for email failures
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/reportEmailPage.ts | Updated email templates to include trackingId parameter |
| src/views/emailPage.ts | Added tracking pixel with URL generation for open detection |
| src/services/reports.js | Integrated email tracking record creation with UUID generation |
| src/services/email.ts | New service to handle email open tracking requests |
| src/routes/emails.ts | New router for email-related endpoints |
| src/routes/admin.js | Added emailModel to admin resources |
| src/modules/stores/mongo.ts | Added email schema for tracking data storage |
| src/modules/slackNotification.ts | Added email failure notification function |
| src/modules/email.ts | Enhanced error handling and TypeScript conversion |
| src/index.ts | Registered email router with origin validation bypass |
| package.json | Updated nodemailer and added uuid dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
kmc7468
requested changes
Jul 22, 2025
kmc7468
reviewed
Jul 29, 2025
kmc7468
reviewed
Jul 29, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
reviewed
Jul 30, 2025
kmc7468
requested changes
Aug 1, 2025
kmc7468
reviewed
Aug 3, 2025
kmc7468
reviewed
Aug 3, 2025
kmc7468
reviewed
Aug 3, 2025
kmc7468
requested changes
Aug 3, 2025
| @@ -1,27 +1,28 @@ | |||
| import type { ObjectId } from "mongoose"; | |||
| import emailPage from "./emailPage"; | |||
| import { frontUrl as origin } from "@/loadenv"; | |||
There was a problem hiding this comment.
reportEmailPage 코드에서 emailPage로 content 파라미터 넘길때 origin을 사용하는 곳이 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #554
Extra info
Images or Screenshots
Further Work