#596 TS 마이그레이션 auth, auth.mobile, auth.replace, chats #601
Conversation
Halo-sparcs
changed the title
kmc7468
changed the title
…authmobile-authreplace-chats
|
@Halo-sparcs JSDoc에 타입이 명시되어 있는 경우가 많은데, (예를 들면 services/chats.ts 파일에 있는 isUserInRoom 함수) TypeScript로 마이그레이션된 경우에는 이미 타입 정보가 함수 자체에 포함이 다 되어 있으니까, JSDoc에서 타입 정보만 삭제하면 어떨까요? 주석도 더 깔끔해질 것 같고, 혹시라도 생길 수 있는 JSDoc과 실제 타입 간의 불일치 문제도 차단할 수 있는 장점이 있는 것 같습니다. 
(예를 들어 위 같은 경우 JSDoc에 있는 string, Promise을 없애자는 의견입니다!) |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the auth, auth.mobile, auth.replace, and chats service modules from JavaScript to TypeScript, adding type annotations, refining imports, and introducing runtime type guards.
- Converted CommonJS
requirecalls to ES moduleimportsyntax and added explicit types. - Introduced
isChatTypeguard inchats.tsand strengthened socket event definitions inmodules/socket.ts. - Updated authentication flows with typed request handlers and adjusted
login/logoutsignatures.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/chats.ts | Converted to TS, added RequestHandler types, isChatType guard and stricter .lean<>() calls |
| src/services/auth.ts | Added interfaces for raw and transformed user data, typed handlers, updated login signature |
| src/services/auth.replace.ts | Typed handlers, refined imports, non-null assertions on session data |
| src/services/auth.mobile.ts | New TS handlers for token-based login/refresh and device registration |
| src/modules/socket.ts | Typed Socket.IO server and events, defined ChatArrayObject, updated JSDoc |
| src/modules/auths/login.ts | Made sid optional in session, adjusted login parameter order |
Comments suppressed due to low confidence (1)
src/modules/socket.ts:43
- The JSDoc for
transformChatsForRoomstill refers to an untypedObject[]; update it to referenceChatArrayObject[]or current TS types for accuracy.
* @param {Object[]} chats - Chats Document에 lean과 populate(chatPopulateOption)을 차례로 적용한 Chat Object의 배열입니다.
| @@ -137,11 +140,30 @@ const loadAfterChatHandler = async (req, res) => { | |||
| } | |||
| }; | |||
|
|
|||
| const sendChatHandler = async (req, res) => { | |||
| function isChatType(x: unknown): x is ChatType { | |||
There was a problem hiding this comment.
The type guard doesn’t include the "departure" chat type, which is valid in ChatType; add it to chatTypeValues so valid messages aren’t rejected.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
zod에서 enum으로 바꿔주면 이제 이 함수는 필요 없어질 것 같네영
|
오.. 코파일럿 리뷰 꽤 괜찮네요! 이상하다 싶은 코멘트는 그냥 거르셔도 될 것 같습니다. |
| @@ -1,11 +1,11 @@ | |||
| const { zodToJsonSchema } = require("zod-to-json-schema"); | |||
| const logger = require("../../modules/logger").default; | |||
|
|
|||
| const zodToSchemaObject = (zodObejct) => { | |||
| const zodToSchemaObject = (zodObject) => { | |||
| const info = { | ||
| id: id, | ||
| sid: id + "-sid", | ||
| name: id + "-name", | ||
| nickname: generateNickname(id), | ||
| profileImageUrl: generateProfileImageUrl(), | ||
| facebook: id + "-facebook", | ||
| twitter: id + "-twitter", | ||
| kaist: "20220411", |
There was a problem hiding this comment.
민후님 학번으로 업데이트 하셔서 흔적(?)을 남기시는건 어떨까요 (농담입니다)
Summary
It closes #596
Extra info
를 ts로 마이그레이션 합니다.