Skip to content

Revert "Revert "#869 [Refactor] Docker 이미지 사이즈 줄이기"" #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

kmc7468
Copy link
Member

@kmc7468 kmc7468 commented Mar 21, 2025

Summary

Reverts #878

  • Taxi의 프론트엔드에서는 환경 변수 주입을 위해 react-inject-env 패키지를 사용합니다. 이는 빌드가 완료된 후, env.js 파일을 생성하여 환경 변수를 주입하는 방식입니다.
  • Taxi의 경우 환경 변수는 빌드 단계가 아닌 컨테이너가 시작되는 단계에서 주입합니다. (참고: https://github.com/sparcs-kaist/taxi-infra/blob/main/docker-compose.yml)
  • 하지만 #869 [Refactor] Docker 이미지 사이즈 줄이기 #870 에서 변경된 Dockerfile에서는 환경 변수를 빌드 단계에서 주입하여, 적절한 환경 변수가 주입되지 않는 문제가 있었습니다.
  • 이 PR에서는 환경 변수를 다시 컨테이너 시작 단계에서 주입하도록 변경하였습니다.

@kmc7468 kmc7468 self-assigned this Mar 21, 2025
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for taxi-dev-preview ready!

Name Link
🔨 Latest commit 9f106a8
🔍 Latest deploy log https://app.netlify.com/sites/taxi-dev-preview/deploys/67dd42bb12546900082d2868
😎 Deploy Preview https://deploy-preview-886--taxi-dev-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kmc7468 kmc7468 added the 😱 bug Something isn't working label Mar 21, 2025
@kmc7468 kmc7468 merged commit eaf0568 into dev Mar 21, 2025
4 checks passed
@kmc7468 kmc7468 deleted the revert-878-revert-870-#869-reduce-docker-image-size branch March 21, 2025 10:48
@kmc7468
Copy link
Member Author

kmc7468 commented Mar 21, 2025

image

알파인 리눅스를 사용한 덕분에 이미지 용량이 더 가벼워졌어요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant