#890 메인 페이지에 공지사항 기능 추가 #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'dev' into 890-show-notice-by-notion
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
kmc7468
reviewed
Jun 24, 2025
Comment on lines
+25
to
+38
| location /notion/ { | ||
| proxy_pass https://www.notion.so/api/v3/; | ||
| proxy_set_header Host www.notion.so; | ||
| proxy_ssl_server_name on; | ||
| proxy_ssl_name www.notion.so; | ||
|
|
||
| add_header 'Access-Control-Allow-Origin' '*'; | ||
| add_header 'Access-Control-Allow-Methods' 'GET, POST, OPTIONS'; | ||
| add_header 'Access-Control-Allow-Headers' '*'; | ||
|
|
||
| if ($request_method = 'OPTIONS') { | ||
| return 204; | ||
| } | ||
| } |
There was a problem hiding this comment.
살짝 걱정되는건 택시 프론트엔드가 아닌 다른 사람들이 악용(?)하지 않을까 걱정되긴 하는데.. 너무 과한 걱정이겠죠
kmc7468
approved these changes
Jun 24, 2025
Mun09
reviewed
Jun 25, 2025
Mun09
reviewed
Jun 25, 2025
|
|
|
pin된 공지사항이 없는 경우에는 그냥 메인에서 아예 안뜨게 하는게 좋을 거 같은데 어떻게 생각하시나용 |
|
그게 더 좋아보이네요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #890
Images or Screenshots
Further Work