#893 유사 시간대 탑승자 방 추천 기능 구현 #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kmc7468
requested changes
Jun 25, 2025
|
PR에 스크린샷도 조금 추가해 주시면 좋을 것 같습니다 |
|
|
kmc7468
reviewed
Jul 1, 2025
kmc7468
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to suggest existing rooms with similar time slots when creating a new room, showing them in a modal before falling back to direct creation.
- Calls
/rooms/searchByTimeGapbefore room creation to fetch similar rooms. - Introduces
ModalSimilarRoomscomponent and integrates it into the AddRoom page. - Exports the new modal in the
ModalPopupindex file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/web/src/pages/Addroom/index.tsx | Added state, search API call, and modal integration |
| packages/web/src/components/ModalPopup/index.tsx | Exported ModalSimilarRooms |
| packages/web/src/components/ModalPopup/ModalSimilarRooms.tsx | Created new modal component for displaying rooms |
Comments suppressed due to low confidence (1)
packages/web/src/pages/Addroom/index.tsx:189
- This new
searchByTimeGapbranch and modal flow lacks dedicated tests. Consider adding unit or integration tests to verify both the cases where similar rooms exist and where they don't.
await axios({
…ider-room-integration-feature-implementation
|
@Mun09 앗 CI 통과 실패했어요! 수정 부탁드립니다 |
Mun09
deleted the
893-similar-timeslot-rider-room-integration-feature-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #893
Extra Info
방 개설 시도 시 유사 시간대 방들을 보여주는 모달 추가