Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared classes being defined both in unit tests and Sparkle #2629

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix shared classes being defined both in unit tests and Sparkle #2629

merged 1 commit into from
Sep 17, 2024

Conversation

zorgiepoo
Copy link
Member

For the unit tests, we will rename the classes so they don't conflict.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

macOS version tested: 14.6.1 (23G93)

@zorgiepoo
Fix shared classes being defined both in unit tests and Sparkle
3731b6d 
For the unit tests, we will rename the classes so they don't conflict.
@zorgiepoo zorgiepoo added this to the 2.7 milestone Sep 16, 2024
@zorgiepoo zorgiepoo merged commit 8de8db0 into 2.x Sep 17, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the fix-test-duplicate-class-definitions branch September 17, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
1 participant
@zorgiepoo