Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process recovery suggestion from Sparkle update error messages in UI alert #2689

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Jan 21, 2025

Brought up as one issue in discussion #2688

If there is a recovery suggestion in the update error, we will use that as the informative text, and the error description as the message text (instead of generic Update Error!)

Also remove an extraneous comma where it doesn't belong in the disk image error message.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested running app from disk image and checking for updates
Tested running app in translocated state and checking for updates
Tested running app in another language (Hebrew) and checking for updates from translocated state.
Tested running app in another language (Hebrew) and checking for updates from disk image.

macOS version tested: 15.2 (24C101)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Jan 21, 2025
@zorgiepoo
Copy link
Member Author

zorgiepoo commented Jan 21, 2025

Likely a side effect / fallout from #1516

@zorgiepoo
Copy link
Member Author

Screenshot 2025-01-20 at 8 39 16 PM Screenshot 2025-01-20 at 8 39 24 PM

@zorgiepoo zorgiepoo merged commit 19ff91d into 2.x Jan 21, 2025
2 checks passed
@zorgiepoo zorgiepoo deleted the recovery-suggestion-update-error branch January 21, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant