Skip to content

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Oct 11, 2025

Include app name in startUpdater: failure in SPUStandardUpdaterController.

The localizations for this are stale now, but I don't consider it a huge issue as ideally this message should not occur in production (unless the user corrupted an app or developer didn't test their app).

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested modified version of test app that uses SPUStandardUpdaterController and removes Ed key in plist

macOS version tested: 26.0.1 (25A362)

@zorgiepoo zorgiepoo added this to the 2.8.1 milestone Oct 11, 2025
Copy link

   93 |             alert.messageText = @"Unable to Check For Updates";
      |                   ^~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')
note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') ```

@zorgiepoo zorgiepoo merged commit 687ef39 into 2.x Oct 11, 2025
2 checks passed
@zorgiepoo zorgiepoo deleted the push-vxvpxsnxtnot branch October 11, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant