ci: add jruby coverage for ruby-saml #3465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-ci-ruby-saml
branch
2 times, most recently
from
dc4a043 to
ab9f018
Compare
flavorjones
force-pushed
the
flavorjones-ci-ruby-saml
branch
from
ab9f018 to
6e286f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
ruby-saml is in the process of migrating off REXML, and have been finding edge case bugs including long-standing JRuby impl bugs, so I want to make sure we have jruby coverage as well as cruby coverage on that project.
I'm not going to add truffleruby coverage. We're testing Nokogiri against truffleruby and truffleruby-head already, and it uses the C extension, so testing ruby-saml with it doesn't provide additional test coverage, but it would provide a rich source of false negatives (see truffleruby/truffleruby#3503 for context).