Skip to content

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 1, 2025

Closes #2902

What problem is this PR intended to solve?

By having xmlsec as part of the core Nokogiri gem, we avoid the issues discussed in #2746. It also enables pre-compiled binary gems of xmlsec for all supported platforms by leveraging Nokogiri's pre-existing infrastructure for this.

Have you included adequate test coverage?

Yes.

Does this change affect the behavior of either the C or the Java implementations?

For now, this is C only.

@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 1, 2025

At this point, all functionality works in CI (pending #3533). I do want to write some more tests, and improve the documentation. There is also still the issue that as-is this does not statically link OpenSSL, and depends on it being available already (as part of Ruby or from the OS). See discussion at #2902 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Epic: merge nokogiri-xmlsec into Nokogiri

1 participant