Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: setup nightly release #524

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

build: setup nightly release #524

wants to merge 34 commits into from

Conversation

goetzrobin
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Robin has to manually release the next version of spartan

Closes #478

What is the new behavior?

We release a new version every night if there was a change to the repository within the last 24 hours.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

this executor finds all package.json in the libs/ui directory
and replaces the current version
of @spartan-ng with the one defined in UI_VERSION
and a unit test to make sure we don't accidentally mess with other packages
Copy link
Collaborator

@ashley-hunter ashley-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will be great to get this! Nice work!

export const SPARTAN_TABS_VERSION = '0.0.1-alpha.357';
export const SPARTAN_TABLE_VERSION = '0.0.1-alpha.357';
export const SPARTAN_TOGGLE_VERSION = '0.0.1-alpha.357';
export const SPARTAN_ACCORDION_BRAIN_VERSION = '0.0.1-alpha.381';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, did not think of this before, but is this still useful?
don't we just have only one brain version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! I think we can remove a bunch of complexity with versions as we just depend on the single brain package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: automate releases with semantic versioning
3 participants