-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: setup nightly release #524
base: main
Are you sure you want to change the base?
Conversation
this executor finds all package.json in the libs/ui directory and replaces the current version of @spartan-ng with the one defined in UI_VERSION
…ke publishing easier
and a unit test to make sure we don't accidentally mess with other packages
74bb3d4
to
16c9b14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Will be great to get this! Nice work!
export const SPARTAN_TABS_VERSION = '0.0.1-alpha.357'; | ||
export const SPARTAN_TABLE_VERSION = '0.0.1-alpha.357'; | ||
export const SPARTAN_TOGGLE_VERSION = '0.0.1-alpha.357'; | ||
export const SPARTAN_ACCORDION_BRAIN_VERSION = '0.0.1-alpha.381'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, did not think of this before, but is this still useful?
don't we just have only one brain version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point! I think we can remove a bunch of complexity with versions as we just depend on the single brain package!
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Robin has to manually release the next version of spartan
Closes #478
What is the new behavior?
We release a new version every night if there was a change to the repository within the last 24 hours.
Does this PR introduce a breaking change?
Other information