feat(icon): icon component migration #537
Open
+1,415
−772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Currently we wrap the NgIcon component which adds a hard dependency on the library and more specifically can lead to us being tied to a specific version and make it hard to update if there are ever any breaking changes.
This pull request changes the component we had to a directive that applies the little bit of custom styling we add, this removes the hard dependency on any specific version of NgIcons.
What is the new behavior?
We use the ng-icon component directly and add an attribute for the styling
Does this PR introduce a breaking change?
Other information
I have added an automated migration to assist in the process of migration as this is a breaking change