chore: add .nvmrc file for Node.js version 22.9.0 #542
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajitzero
reviewed
Dec 25, 2024
| @@ -0,0 +1 @@ | |||
| 22.9.0 | |||
There was a problem hiding this comment.
Thanks for this! I just noticed that we don't mention anything like this in the contributing guide, etc., but should have been added. Maybe with a different PR?
A couple of points:
- Please include a
.node-versionfile with the same contents. Thanks to fragmentation between node version managers, every tool exceptnvmlooks for a.node-versionfile. Whilenvmis stable on macOS/Linux, it often enters a problematic state in Windows, so many people have switched to other alternatives. - I can't recall where I remember this from, but
.nvmrc(and.node-version) should only include the major version to allow for easy upgrades through minor versions.
Suggested change
| 22.9.0 | |
| 22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Currently, there is no
.nvmrcfile in the repository, which can lead to inconsistencies in the Node.js version used by contributors.Closes: N/A
What is the new behavior?
The
.nvmrcfile has been added to specify the recommended Node.js version, ensuring that all contributors use the same version during development.Does this PR introduce a breaking change?
Other information
This is an initial step to improve developer experience by introducing Node.js version management through
.nvmrc.