feat(button): add anchor button #797 #798
Open
+137
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @ashley-hunter as already discussed in Discord, here is my solution for that :) If you have any sugestions, please let me know |
|
@MerlinMoos - Just curious, what's the reason for the separate set of directives? Could we not just determine what the host element is in a new brnButton directive and if it's attached to an anchor do the logic you have there or maybe I'm missing something |
MerlinMoos
force-pushed
the
add-disabled-to-anchor
branch
from
697fffc to
76e1585
Compare
|
hey @thatsamsonkid you are right, I changed it. Maybe you can have a second look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/spartan-ng/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
Primitives
Others
What is the current behavior?
Currently it's not possible to to disable a hlmBtn on a element
Closes #797
What is the new behavior?
Does this PR introduce a breaking change?
Other information