Add missing payload renormalization for morphDataClass #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is documented at https://spatie.be/docs/laravel-data/v4/as-a-data-transfer-object/abstract-data but the behavior you described is not. I just ran into this myself which is how I found the issue. |
|
@rubenvanassche Any chance you could review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, so I am using abstract data with PropertyMorphableData contract implemented, but when correct data class is resolved, it only contains properties that are defined in that abstract class. This PR fixes that issue by renormalizing payload for correct morphDataClass. It is also a shame that this feature is not documented at all.