Fix for the use of built-in class names in Collection annotations #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, found this when upgrading from v3 to v4.
In v3 you could do
which would correctly pick up a class with the right namespace, even if its basename matches a builtin like
\Error
.In v4 the same syntax is:
But due to the order in which the
DataIterableAnnotationReader
determines the correct class, it discovers\Error
beforeApp\Stuff\Error
or similar.This PR reorders the resolution code so that it finds properly qualified classes before builtins.