Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing for me locally and on some branch builds. E.g. for the same commit:
I believe this is happening because of an update to
phpdocumentor/reflection-docblock
that added support for more specific docblock types: https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.5.0This means that the returned tag classes for the
@extends
and@template
are new specific classes instead of the "Generic" class they previously were.Unfortunately this dependency is loaded indirectly via
phpdocumentor/reflection
and their requirement forphpdocumentor/reflection-docblock
is just^5
. So I've added^5.5
to ensure we have the required classes and to make the check more consistent.