Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing annotation tests #917

Closed
wants to merge 3 commits into from

Conversation

bentleyo
Copy link
Contributor

Tests were failing for me locally and on some branch builds. E.g. for the same commit:

I believe this is happening because of an update to phpdocumentor/reflection-docblock that added support for more specific docblock types: https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.5.0

This means that the returned tag classes for the @extends and @template are new specific classes instead of the "Generic" class they previously were.

Unfortunately this dependency is loaded indirectly via phpdocumentor/reflection and their requirement for phpdocumentor/reflection-docblock is just ^5. So I've added ^5.5 to ensure we have the required classes and to make the check more consistent.

@freekmurze
Copy link
Member

This was fixed by another PR

@freekmurze freekmurze closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants