Fix DivisionByZeroError in File::getHumanReadable() (#3549)

* Fix DivisionByZeroError * Use triple equal * Change back to double equals comparison * test for 0 bytes
spatie · Feb 20, 2024 · 899d7f6 · 899d7f6
1 parent 1d56eac
commit 899d7f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Support/File.php b/src/Support/File.php
@@ -10,6 +10,11 @@ public static function getHumanReadableSize(int|float $sizeInBytes): string
     {
         $units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
 
+        // 0 === 0.00 return false so use double equals
+        if ($sizeInBytes == 0) {
+            return '0 '.$units[0];
+        }
+
         $index = min(count($units) - 1, floor(log(abs($sizeInBytes), 1024)));
 
         return sprintf('%s %s', round(num: abs($sizeInBytes) / (1024 ** $index), precision: 2), $units[$index]);

diff --git a/tests/Support/FileTest.php b/tests/Support/FileTest.php
@@ -3,6 +3,7 @@
 use Spatie\MediaLibrary\Support\File;
 
 it('can determine a human readable filesize', function () {
+    expect(File::getHumanReadableSize(0))->toEqual('0 B');
     expect(File::getHumanReadableSize(10))->toEqual('10 B');
     expect(File::getHumanReadableSize(100))->toEqual('100 B');
     expect(File::getHumanReadableSize(1000))->toEqual('1000 B');