Fill missing settings with default values #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you deploy a new version to a server and the migrations are still running you get a
MissingSettings
exception. For long running migrations and big deployments this can be a problem.This proposal adds a fallback option to settings defined in the
Settings
object. If you set the default in the code the settings mapper will return that default value instead of throwing an exception. For nullable values the default will be null without changing anything in theSettings
object.Example:
What do you think about this proposal?
Credits to @andrasszommer